Conversation
Fedr
requested changes
Aug 12, 2022
source/MRMesh/MRMatrix4.h
Outdated
| constexpr T normSq() const noexcept { return x.lengthSq() + y.lengthSq() + z.lengthSq() + w.lengthSq(); } | ||
| constexpr T norm() const noexcept { return std::sqrt( normSq() ); } | ||
| /// computes submatrix | ||
| constexpr Matrix3<T> submatrix( int i, int j ) const noexcept; |
Contributor
There was a problem hiding this comment.
better name submatrix3 and explain what is i and j in the comment
source/MRViewer/MRViewport.cpp
Outdated
| { | ||
| auto norm = normTemp.norm(); | ||
| assert( std::isnormal( norm ) ); | ||
| normTemp /= norm; |
Contributor
There was a problem hiding this comment.
We can be here if norm == 0, so we should check this before division
Contributor
Author
There was a problem hiding this comment.
std::isnormal checks for zero either.
Contributor
There was a problem hiding this comment.
yes, but assert is only in Debug, but we need a check for Release as well
source/MRViewer/MRViewportCamera.cpp
Outdated
| namespace | ||
| { | ||
|
|
||
| constexpr float cMaxObjectScale = 1e9; |
Contributor
There was a problem hiding this comment.
constexpr float cMaxObjectScaleSq = 1e9f;
and please add some comment
Fedr
reviewed
Aug 12, 2022
source/MRViewer/MRViewportCamera.cpp
Outdated
| namespace | ||
| { | ||
|
|
||
| /// maximum supported distance to rotation pivot |
Fedr
reviewed
Aug 12, 2022
source/MRMesh/MRObject.cpp
Outdated
| if ( xf_ == xf ) | ||
| return; | ||
| xf_ = xf; | ||
| if ( Matrix4( xf ).det() == 0 ) |
Contributor
There was a problem hiding this comment.
xf.A.det() == 0 is faster here
Fedr
approved these changes
Aug 12, 2022
Grantim
approved these changes
Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.