Merged
Conversation
Fedr
reviewed
Nov 16, 2024
source/MRMesh/MRMeshPart.h
Outdated
| // In modern C++ the result doesn't need to be `std::launder`ed, right? | ||
| this->~MeshPart(); | ||
| ::new((void *)this) MeshPart(other); | ||
| ::new( ( void* )this ) MeshPart( other ); |
Fedr
reviewed
Nov 16, 2024
Comment on lines
+23
to
+24
| const ObjectMesh& oldMesh, | ||
| const MeshPart& mp, |
Contributor
There was a problem hiding this comment.
Suggested change
| const ObjectMesh& oldMesh, | |
| const MeshPart& mp, | |
| const ObjectMesh& oldMeshObj, | |
| const MeshPart& newMeshPart, |
|
|
||
| VertBitSet vertRegion; | ||
| MeshVertPart mvp( newMesh ); | ||
| if ( mp.region ) |
Contributor
There was a problem hiding this comment.
Make it inside hasVertAttribs branch?
| FaceColors faceColors; | ||
| }; | ||
|
|
||
| // projecting the attributes of the old mesh onto the new |
Contributor
There was a problem hiding this comment.
Suggested change
| // projecting the attributes of the old mesh onto the new | |
| /// finds attributes of new mesh part by projecting region's faces/vertices on old mesh |
Fedr
approved these changes
Nov 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MeshRegion<T>and unifyMeshPartandMeshVertPartMeshRegionin attributes projection function