Conversation
Grantim
requested changes
Aug 23, 2022
Comment on lines
-359
to
+355
| auto res = calcTextureRes( int( facesColorMap.size() ), maxTexSize ); | ||
| auto res = calcTextureRes( int( facesColorMap.size() ), maxTexSize_ ); |
Contributor
There was a problem hiding this comment.
can we calc texture resolution only in update_ and not calc it twice
Contributor
Author
There was a problem hiding this comment.
facesColorMap is pre-calculated outside this class.
source/MRMesh/MRMeshNormals.cpp
Outdated
Comment on lines
33
to
44
|
|
||
| Buffer<Vector4f> computePerFaceNormals4( const Mesh & mesh ) | ||
| Buffer<Vector4f> computePerFaceNormals4( const Mesh & mesh, size_t bufferSize ) | ||
| { | ||
| MR_TIMER | ||
| FaceId lastValidFace = mesh.topology.lastValidFace(); | ||
|
|
||
| const auto & edgePerFace = mesh.topology.edgePerFace(); | ||
| Buffer<Vector4f> res( lastValidFace + 1 ); | ||
| if ( bufferSize != 0 ) | ||
| assert( bufferSize >= lastValidFace + 1 ); | ||
| else | ||
| bufferSize = lastValidFace + 1; | ||
| Buffer<Vector4f> res( bufferSize ); | ||
| tbb::parallel_for( tbb::blocked_range<FaceId>( FaceId{0}, lastValidFace + 1 ), [&]( const tbb::blocked_range<FaceId> & range ) |
Contributor
There was a problem hiding this comment.
mb better Buffer<Vector4f>& outBuffer as arg?
Contributor
There was a problem hiding this comment.
or simply pointer Vector4f* as arg
Fedr
approved these changes
Aug 23, 2022
Grantim
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.