Skip to content

Enable SecondaryCaptureImageStorage (with a warning). #4244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewerf merged 1 commit into from
Mar 11, 2025
Merged

Enable SecondaryCaptureImageStorage (with a warning). #4244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions source/MRVoxels/MRDicom.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,13 +765,17 @@ DicomStatus isDicomFile( const std::filesystem::path& path, std::string* seriesU
ms.SetFromFile( ir.GetFile() );

// skip unsupported media storage
if ( ms == gdcm::MediaStorage::MediaStorageDirectoryStorage || ms == gdcm::MediaStorage::SecondaryCaptureImageStorage
|| ms == gdcm::MediaStorage::BasicTextSR )
if ( ms == gdcm::MediaStorage::MediaStorageDirectoryStorage || ms == gdcm::MediaStorage::BasicTextSR )
{
spdlog::warn( "DICOM file {} has unsupported media storage {}", utf8string( path ), (int)ms );
return { DicomStatusEnum::Unsupported, "unsupported media storage" };
}

if ( ms == gdcm::MediaStorage::SecondaryCaptureImageStorage )
{
spdlog::warn( "DICOM file {} has media storage type: SecondaryCaptureImageStorage, which may not be fully supported" );
}

// unfortunatly gdcm::ImageHelper::GetPhotometricInterpretationValue returns something even if no data in the file
if ( !gdcm::ImageHelper::GetPointerFromElement( gdcm::Keywords::PhotometricInterpretation::GetTag(), ir.GetFile() ) )
{
Expand Down
Loading