Use single buffer for all render class instances#429
Merged
Conversation
oitel
force-pushed
the
single_render_buffer
branch
from
f6389a1 to
f3fe17e
Compare
Grantim
reviewed
Aug 30, 2022
| // This class holds all shaders that are used in the program | ||
| // creates shader on access if it is needed | ||
| class ShadersHolder | ||
| class GLStaticHolder |
Contributor
There was a problem hiding this comment.
please update comment about this class
Contributor
There was a problem hiding this comment.
also please add
using ShadersHolder [[deprecated]] = GLStaticHolder;
source/MRViewer/MRGLStaticHolder.cpp
Outdated
Comment on lines
+1246
to
+1247
| static RenderObjectBuffer glBuffer; | ||
| return glBuffer; |
Contributor
There was a problem hiding this comment.
let it be member of GLStaticHolder and
return instance_().glBuffer_;
source/MRViewer/MRRenderHelpers.h
Outdated
| // provides shared buffer for loading different types of data to GL memory | ||
| class RenderObjectBuffer | ||
| { | ||
| friend class GLStaticHolder; |
Contributor
Author
There was a problem hiding this comment.
To make the constructor private.
Grantim
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.