Merged
Conversation
changed getFontSize to static
Grantim
reviewed
Aug 31, 2022
| MRVIEWER_API ImFont* getFontByType( FontType type ) const; | ||
| /// get font size by font type | ||
| MRVIEWER_API float getFontSizeByType( FontType type ) const; | ||
| static float getFontSizeByType( FontType type ); |
| /// initialize static holder for easier access to ribbon fonts | ||
| /// (need to avoid dynamic cast menu to ribbon menu) | ||
| void initFontManagerInstance( RibbonFontManager* ribbonFontManager ); | ||
| static void initFontManagerInstance( RibbonFontManager* ribbonFontManager ); |
| void initFontManagerInstance( RibbonFontManager* ribbonFontManager ); | ||
| static void initFontManagerInstance( RibbonFontManager* ribbonFontManager ); | ||
|
|
||
| static bool istanceExists() { return getFontManagerInstance_(); }; |
Contributor
There was a problem hiding this comment.
add comment or remove this
Grantim
approved these changes
Aug 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaced getFont to static version
changed getFontSize to static