Merged
Conversation
Grantim
reviewed
Sep 16, 2022
| "y - float Y coordinate of depth map: (0.0f - left corner of pixel 0, 1.0 - right corner of pixel 0 and left corner of pixel 1)\n" | ||
| "depth - value in distance map, represent depth in world" ). | ||
| def_readwrite( "orgPoint", &MR::DistanceMapToWorld::orgPoint, "World coordinates of distance map origin corner" ). | ||
| def_readwrite( "pixelXVec", &MR::DistanceMapToWorld::pixelXVec, "Vector in world space of pixel x positive direction." |
Contributor
There was a problem hiding this comment.
\n at the end of first comment line
| def_readwrite( "maxValue", &MR::MeshToDistanceMapParams::maxValue, "Using of this parameter depends on useDistanceLimits" ). | ||
| def_readwrite( "resolution", &MR::MeshToDistanceMapParams::resolution, "resolution of distance map" ); | ||
|
|
||
| pybind11::class_<MR::DistanceMapToWorld>( m, "DistanceMapToWorld" ). |
Contributor
There was a problem hiding this comment.
pybind11::class_<MR::DistanceMapToWorld>( m, "DistanceMapToWorld", "This structure store data to transform distance map to world coordinates" ).| def_readwrite( "orgPoint", &MR::DistanceMapToWorld::orgPoint, "World coordinates of distance map origin corner" ). | ||
| def_readwrite( "pixelXVec", &MR::DistanceMapToWorld::pixelXVec, "Vector in world space of pixel x positive direction." | ||
| "Length is equal to pixel size. Typically it should be orthogonal to `pixelYVec`." ). | ||
| def_readwrite( "pixelYVec", &MR::DistanceMapToWorld::pixelYVec, "Vector in world space of pixel y positive direction." |
Contributor
There was a problem hiding this comment.
\n at the end of first comment line
| "depth - value in distance map, represent depth in world" ). | ||
| def_readwrite( "orgPoint", &MR::DistanceMapToWorld::orgPoint, "World coordinates of distance map origin corner" ). | ||
| def_readwrite( "pixelXVec", &MR::DistanceMapToWorld::pixelXVec, "Vector in world space of pixel x positive direction." | ||
| "Length is equal to pixel size. Typically it should be orthogonal to `pixelYVec`." ). |
Contributor
There was a problem hiding this comment.
please add note comment too
Grantim
approved these changes
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MeshInspector/MeshInspectorCode#1165