Add option to force reset config on start of application #5223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedr
approved these changes
Oct 10, 2025
Comment on lines
38
to
42
| cfg.reset( appName ); | ||
| if ( reset ) | ||
| { | ||
| cfg.setFullConfig( Json::Value() ); | ||
| cfg.reset( appName ); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| cfg.reset( appName ); | |
| if ( reset ) | |
| { | |
| cfg.setFullConfig( Json::Value() ); | |
| cfg.reset( appName ); | |
| } | |
| if ( reset ) | |
| cfg.setFullConfig( Json::Value() ); | |
| cfg.reset( appName ); |
Contributor
Author
There was a problem hiding this comment.
will not work this way, let me add comment
source/MRViewer/MRSetupViewer.h
Outdated
| /// Sets custom viewer settings manager to viewer | ||
| MRVIEWER_API virtual void setupSettingsManager( Viewer* viewer, const std::string& appName ) const; | ||
| /// reset - flags indicates that user launched application with request for reseting config file | ||
| MRVIEWER_API virtual void setupSettingsManager( Viewer* viewer, const std::string& appName, bool reset ) const; |
Contributor
There was a problem hiding this comment.
Suggested change
| MRVIEWER_API virtual void setupSettingsManager( Viewer* viewer, const std::string& appName, bool reset ) const; | |
| MRVIEWER_API virtual void setupSettingsManager( Viewer* viewer, const std::string& appName, bool reset = false ) const; |
oitel
approved these changes
Oct 10, 2025
source/MRMesh/MRConfig.h
Outdated
| MRMESH_API void setJsonValue( const std::string& key, const Json::Value& keyValue ); | ||
|
|
||
| /// returns json with content of this config | ||
| Json::Value getFullConfig() const { return config_; } |
source/MRMesh/MRConfig.h
Outdated
| Json::Value getFullConfig() const { return config_; } | ||
|
|
||
| /// replace current config content with given one | ||
| void setFullConfig( const Json::Value& config ) { config_ = config; } |
Comment on lines
38
to
42
| cfg.reset( appName ); | ||
| if ( reset ) | ||
| { | ||
| cfg.setFullConfig( Json::Value() ); | ||
| cfg.reset( appName ); | ||
| } |
Contributor
There was a problem hiding this comment.
Do we need to call setFullConfig between two resets rather than before one?
source/MRViewer/MRSetupViewer.h
Outdated
| /// Sets custom viewer settings manager to viewer | ||
| MRVIEWER_API virtual void setupSettingsManager( Viewer* viewer, const std::string& appName ) const; | ||
| /// reset - flags indicates that user launched application with request for reseting config file | ||
| MRVIEWER_API virtual void setupSettingsManager( Viewer* viewer, const std::string& appName, bool reset ) const; |
Contributor
There was a problem hiding this comment.
bool reset = false by default?
source/MRViewer/MRSetupViewer.h
Outdated
|
|
||
| /// Sets custom viewer settings manager to viewer | ||
| MRVIEWER_API virtual void setupSettingsManager( Viewer* viewer, const std::string& appName ) const; | ||
| /// reset - flags indicates that user launched application with request for reseting config file |
Fedr
approved these changes
Oct 10, 2025
oitel
approved these changes
Oct 10, 2025
Grantim
deleted the
Add_option_to_force_reset_config_on_start_of_application
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.