Conversation
Fedr
reviewed
Sep 21, 2022
source/MRMesh/MRStringConvert.cpp
Outdated
| #else | ||
| std::string systemToUtf8( const char* system ) | ||
| { | ||
| return system; |
Contributor
There was a problem hiding this comment.
The return type may be std::string here, but the conversion inside must remain (for Windows)
Fedr
reviewed
Sep 21, 2022
| #include "MRProgressReadWrite.h" | ||
| #include <fstream> | ||
|
|
||
| #ifndef MRMESH_NO_OPENCTM |
Contributor
There was a problem hiding this comment.
Full source of OpenCTM is in MRMesh, what is wrong with it?
Fedr
reviewed
Sep 21, 2022
Fedr
reviewed
Sep 21, 2022
source/MRMesh/MRPointsLoad.cpp
Outdated
|
|
||
| return fromCtm( in, colors, callback ); | ||
| #else | ||
| return tl::make_unexpected( "This build has no OpenCTM support" ); |
Contributor
There was a problem hiding this comment.
probably completely remove fromCtm function and the like if MRMESH_NO_OPENCTM?
Grantim
reviewed
Sep 23, 2022
source/MRMesh/MRObjectLabel.h
Outdated
Comment on lines
+152
to
+156
| #ifndef MRMESH_NO_OPENCTM | ||
| MRMESH_API virtual tl::expected<std::future<void>, std::string> serializeModel_( const std::filesystem::path& path ) const override; | ||
|
|
||
| MRMESH_API virtual tl::expected<void, std::string> deserializeModel_( const std::filesystem::path& path, ProgressCallback progressCb = {} ) override; | ||
| #endif |
Contributor
There was a problem hiding this comment.
mb better to export in other format then not export at all
Fedr
approved these changes
Sep 23, 2022
Grantim
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.