Merged
Conversation
adalisk-emikhaylov
added
the
skip-image-rebuild
Grantim
reviewed
Apr 15, 2026
adalisk-emikhaylov
added
the
skip-image-rebuild
Grantim
reviewed
Apr 17, 2026
|
|
||
| #include "exports.h" | ||
|
|
||
| #include <nlohmann/json.hpp> |
Contributor
There was a problem hiding this comment.
should it be hidden in cpp?
Comment on lines
+46
to
+48
| /// Launch the MCP server. Append this to the `CommandLoop` instead of calling immediately. | ||
| /// Returns false if the MCP support is not compiled in. | ||
| MRVIEWER_API virtual bool setupMcp() const; |
Contributor
There was a problem hiding this comment.
why not use command loop inside?
Why add new function and not using one of existing?
oitel
reviewed
Apr 17, 2026
| { | ||
|
|
||
| /// This is used to build json schemas. | ||
| namespace Schema |
Contributor
There was a problem hiding this comment.
Maybe better to move it to a separate header MRMcpSchema.h?
| CommandLoop::appendCommand( [&] () | ||
| { | ||
| setup.setupExtendedLibraries(); | ||
| setup.setupMcp(); |
Contributor
There was a problem hiding this comment.
Make it conditional: add an option to LaunchParams and set it disabled by default.
oitel
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.