reworked ObjectVoxels for adding to python#609
Merged
Conversation
…o i1242_python_load_voxels # Conflicts: # source/MRMesh/MRObjectVoxels.cpp
rename saveRAW to saveRaw
Contributor
Author
|
MeshInspector/MeshInspectorCode/issues/1242 |
Grantim
reviewed
Oct 18, 2022
source/MRMesh/MRVoxelsLoad.h
Outdated
| { | ||
| Vector3i dimensions; | ||
| Vector3f voxelSize; | ||
| bool gridLevelSet{ false }; |
Contributor
There was a problem hiding this comment.
please add comment about this field
Comment on lines
+619
to
625
| auto gtEndChar = filename.find( "_", zvEndChar + 1 ); | ||
| if ( gtEndChar != std::string::npos ) | ||
| { | ||
| auto gtString = filename.substr( zvEndChar + 1, gtEndChar - ( zvEndChar + 1 ) ); | ||
| outParams.gridLevelSet = gtString == "1"; // convert mm to meters | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
will it work with old files without G prefix?
source/MRMesh/MRVoxelsLoad.cpp
Outdated
|
|
||
| VdbVolume res; | ||
| res.data = simpleVolumeToDenseGrid( outVolume ); | ||
| res.data->setGridClass( openvdb::GRID_LEVEL_SET ); |
Contributor
There was a problem hiding this comment.
please use value from params
Grantim
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.