Track and display aggregated sample counts in passive RX log entries#166
Merged
Conversation
Co-authored-by: MrAlders0n <55921894+MrAlders0n@users.noreply.github.com>
Co-authored-by: MrAlders0n <55921894+MrAlders0n@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Store aggregated sample count in RX log entries
Track and display aggregated sample counts in passive RX log entries
Dec 31, 2025
There was a problem hiding this comment.
Pull request overview
This PR implements tracking and display of aggregated sample counts in passive RX log entries. Previously, the batch aggregation system calculated sample_count when flushing repeater observations but did not persist it in RX log entries, resulting in CSV exports always showing SampleCount: 1 even for aggregated batches.
Key Changes
- Modified
addRxLogEntry()to accept and store asampleCountparameter (defaults to 1 for backward compatibility) - Updated
queueApiPost()to pass the aggregatedsample_countfrom batch entries to RX log storage - Enhanced
createRxLogEntryElement()to display a visual badge (e.g., "x2", "x3") beside repeater chips when entries represent multiple aggregated samples
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The batch aggregation system was calculating
sample_countwhen flushing repeater observations but not persisting it in RX log entries. CSV exports always showedSampleCount: 1even for aggregated batches.Changes
addRxLogEntry(): AddedsampleCountparameter (default: 1) to persist aggregated sample counts in log entriesqueueApiPost(): Propagatesentry.sample_countfrom batch flush to RX log entrycreateRxLogEntryElement(): Displays "x2", "x3", etc. badge beside repeater chip whensampleCount > 1CSV export: Already handled
sampleCountfield with fallback to 1 for backward compatibility.UI: Badge appears as
<span class="text-xs text-slate-400 ml-1">x{count}</span>beside repeater chips for aggregated entries.Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.