Add GPS status feedback and freshness validation for ping operations#49
Merged
MrAlders0n merged 4 commits intodevfrom Dec 18, 2025
Merged
Add GPS status feedback and freshness validation for ping operations#49MrAlders0n merged 4 commits intodevfrom
MrAlders0n merged 4 commits intodevfrom
Conversation
- Manual ping now shows "GPS data too old, requesting fresh position" when requesting fresh GPS - Manual ping shows "Error: could not get fresh GPS location" on timeout - Auto ping validates GPS freshness before sending - Auto ping shows "GPS data old, trying to refresh position" when refreshing - Auto ping shows "GPS could not refresh position, skipping ping. Next attempt (Xs)" on failure - Auto ping schedules next attempt when GPS refresh fails Co-authored-by: MrAlders0n <55921894+MrAlders0n@users.noreply.github.com>
- Created acquireFreshGpsPosition() helper to eliminate code duplication - Reduces duplication between auto and manual GPS acquisition - Improves code maintainability and readability Co-authored-by: MrAlders0n <55921894+MrAlders0n@users.noreply.github.com>
Co-authored-by: MrAlders0n <55921894+MrAlders0n@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve GPS status feedback during ping operations
Add GPS status feedback and freshness validation for ping operations
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When GPS data was stale, manual pings silently requested fresh position without user feedback, eventually timing out with generic "ping timeout". Auto ping mode sent pings regardless of GPS data age, with no freshness validation.
Changes
Manual ping:
"GPS data too old, requesting fresh position"when requesting fresh GPS"Error: could not get fresh GPS location"on timeout instead of generic errorAuto ping:
"GPS data old, trying to refresh position"when attempting refresh"GPS could not refresh position, skipping ping. Next attempt (Xs)"on failureImplementation:
Extracted
acquireFreshGpsPosition()helper to eliminate duplication between auto and manual GPS acquisition paths.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.