Skip to content

Fix trac log generator counts table#128

Merged
arjclark merged 1 commit intoMetOffice:mainfrom
arjclark:fix_log_generator_counts_table
Mar 5, 2026
Merged

Fix trac log generator counts table#128
arjclark merged 1 commit intoMetOffice:mainfrom
arjclark:fix_log_generator_counts_table

Conversation

@arjclark
Copy link
Collaborator

@arjclark arjclark commented Mar 4, 2026

ANTS rose stem logs

ants_counts/run1


Testing

For core ANTS only tests, the bare minimum that will be accepted is the --group=unittests but many, if not most, changes will need to test other groups to ensure they meet reviewer expectations. In general, it should be possible and is advised to run the --group=all group prior to review submission as this will catch any consequential issues. Additionally you must run the ancillary-file-science tests, pointing at your branch, with --group=all to capture any behaviour changes affecting Science codes.

If your change will alter existing science results, you will need to seek appropriate Scientific validation and confirm that the model has been initialised with your new development. Inspecting a change in xconv/pyplot/visualiser of choice is not sufficient to demonstrate the model can be initialised from your file.


Impact of change

  • This will maintain results for ANTS rose stem --group=all tests
  • This will this maintain results for ancillary-file-science rose stem --group=all tests
  • If this change adds a new capability, evidence has been supplied to show testing of ancillary generation across different resolutions e.g. For global ancillary generation capabilities for use in NWP n1280e is expected to have been tested
  • This change has significantly impacted required resources (runtime and memory) in existing ancillary generation (if yes, give details)
  • This change alters existing ancils
Updates the counts in the logs table.

Approvals for this change

  • I have approval from the ANTS core development team for these changes

New functionality further testing

  • If adding new functionality to existing codes, I confirm that the new code doesn't change results when it is switched off and ''works'' when switched on
  • Unittests have been added
  • Rose stem tests have been added for any new functionality
  • If adding new functionality please confirm that the new code compares across different standard decompositions.
  • I have not encountered any failures in my rose-stem output(s)
    These tasks must succeed for your ticket to pass review.
  • I have remembered to run the code style check tasks/tools
Checked via running rose-stem with unittests group. Reviewer should construct a failed task and schutdown scenario to their satisfaction.

Other

  • I read the Contributor Licence Agreement
  • I have added my name and affiliation to the Contributors list if I am not already on there.
  • The issue labels, milestones, etc. are correct
  • Links to all related issues have been provided in the pull request description
  • I have requested a code reviewer
  • Source data has been added or changed - please include a link to the license
I confirm that all code is my own and that my contributions are not subject to copyright or license restrictions (see Contributor Licence Agreement). Andrew Clark
I confirm I have not knowingly violated intellectual property rights (IPR) and have taken sensible measures to prevent doing so, including appropriate attribution for usage of Generative AI. I confirm that this work is my own, and I understand that it is my responsibility to ensure I am not violating others’ IPR. This includes taking reasonable steps to ensure that all tools used while creating this contribution did not infringe IPR. Andrew Clark
Please add any further notes here. If Generative AI tools have been used, a brief summary (e.g. "Github copilot used to add extra unittests") should be provided.

Rose stem logs

Please copy in the contents of your trac_status.log file(s) below (found in the cylc-run directory for your rose stem run) to your rose-stem testing here. Note: if your changes lead to a change in answers, you must run rose stem --group=all to help ensure all affected configurations has been flagged up.

Wed 4 Mar 13:54:17 GMT 2026 Git status: [ "" ] Commit: 38be5e2

Test Results - Summary

tasks total
succeeded 5

Test Results - Detail

task status
install_cold succeeded
flake8 succeeded
isort succeeded
black succeeded
unittests succeeded

@arjclark arjclark requested a review from hdyson March 4, 2026 14:39
@arjclark arjclark added this to the 3.1 milestone Mar 4, 2026
@arjclark arjclark self-assigned this Mar 5, 2026
@mo-tgeddes mo-tgeddes requested review from mo-tgeddes and removed request for mo-tgeddes March 5, 2026 10:29
Copy link
Contributor

@hdyson hdyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me 👍

Confirmed it does what is expected for a working workflow, an interrupted workflow, and a deliberately broken workflow.

@arjclark arjclark merged commit b328eeb into MetOffice:main Mar 5, 2026
5 checks passed
@arjclark arjclark deleted the fix_log_generator_counts_table branch March 5, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants