CDDSO-289 modified chunking logic and unit tests#133
Merged
piotr-florek-mohc merged 3 commits intov2.4_releasefrom Jun 21, 2023
Merged
CDDSO-289 modified chunking logic and unit tests#133piotr-florek-mohc merged 3 commits intov2.4_releasefrom
piotr-florek-mohc merged 3 commits intov2.4_releasefrom
Conversation
Collaborator
matthew-mizielinski
left a comment
matthew-mizielinski
left a comment
There was a problem hiding this comment.
I'd just like to clarify the MOOSE_MAX_NC_FILES change justification and then I think we can proceed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR involve refactoring of the chunking logic in the
ppbranch of the code. Chunk size is now calculated and tested for each chunk until reaching the end of the simulation run bounds, which allows us to retrieve data spread unevenly on many tapes in MASS.The
with_ensemble_idparameter is necessary because the usage of the ensemble id in filenames is inconsistent, so we want to try both filename templates (i.e. with the ensemble id and without one).The PR also includes a change in the number of files that can be retrieved in a single
moose filterquery, which is a stopgap solution for the same problem in thencbranch of the chunking logic. This is because changes from CDDSO-245 (#103) are still on themainbranch only (in retrospect I should have merged it inv2.4as well, but I had thought2.4.2would be our last release before2.5.0).