CDDSO-293: remove erroneous y dimension filtering from diaptr files in GCModelDev MM models#136
Merged
matthew-mizielinski merged 2 commits intov2.4_releasefrom Jun 21, 2023
Conversation
…n GCModelDev MM models
…ormation in the CMIP6 plugin
Collaborator
Author
|
I've just updated the pull request after realising I made an egregious error (set the filter to filter the wrong axis for the diaptr files). This is now consistent with the CMIP6 model config files, see CDDS/cdds/cdds/common/plugins/cmip6/data/model/HadGEM3-GC31-MM.json Lines 281 to 283 in 92581f6 |
Collaborator
Author
|
Thanks @mo-jareddrayton , I've also confirmed that this fixes the problem that Laura reported |
matthew-mizielinski
added a commit
that referenced
this pull request
Jun 21, 2023
CDDSO-293: remove erroneous x dimension filtering from diaptr files in GCModelDev MM models
Collaborator
Author
|
merged into main: df58b0d |
matthew-mizielinski
added a commit
that referenced
this pull request
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple change to address the bug that Laura Jackson has just reported. I've checked all other model configurations and these are the only ones affected