CDDSO-333 re-enable cell_methods checking#172
Merged
piotr-florek-mohc merged 2 commits intov2.5_releasefrom Aug 30, 2023
Merged
Conversation
mo-kerstinschmatzer
approved these changes
Aug 30, 2023
Collaborator
mo-kerstinschmatzer
left a comment
mo-kerstinschmatzer
left a comment
There was a problem hiding this comment.
Lgtm. Tests passed. Approved :)
piotr-florek-mohc
added a commit
that referenced
this pull request
Aug 30, 2023
jonseddon
added a commit
that referenced
this pull request
Sep 11, 2023
matthew-mizielinski
deleted the
CDDSO-333-check-cell-methods-consistency-with-mip-tables
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally variable attributes validation was more monolithic, and because the
cell_methodsattribute were causing much trouble early on, so it was disabled entirely. We might want to do a larger variable set runthrough just to be sure, but I don't see any harm in re-enabling it - in principle variable metadata should match what is expected from MIP Tables, and any discrepancies should be reported.