Skip to content

Conversation

@mo-jareddrayton
Copy link
Collaborator

This addresses #668

A few other things we can either pick up now or raise issues for/

cmip7_attributes.py

  • further_info_url -
  • attributesValidator

cmip7_models.py

  • license

@mo-jareddrayton mo-jareddrayton changed the title 668 cmip7 replace any cmip6 references in the cmip7 project plugin 668 CMIP7: replace any cmip6 references in the cmip7 project plugin Nov 4, 2025
@matthew-mizielinski
Copy link
Collaborator

This addresses #668

A few other things we can either pick up now or raise issues for/

cmip7_attributes.py

  • further_info_url -
  • attributesValidator

further_info_url is discontinued as a required attribute in CMIP7, but it might be useful to point at one of the github repos under UKNCSP

attributesValidator -- we can develop this against the global attributes documentation at https://wcrp-cmip.github.io/cmip7-guidance/CMIP7/global_attributes/

cmip7_models.py

  • license

CMOR is handling licenses differently now; I think if you provide "license_id": "CC-BY 4.0" to CMOR it will construct the license text from the CVs and the institution id

Copy link
Collaborator

@matthew-mizielinski matthew-mizielinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@matthew-mizielinski matthew-mizielinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to fix the import in cdds/cdds/common/plugins/plugin_loader.py otherwise everything fails

@mo-jareddrayton
Copy link
Collaborator Author

This addresses #668
A few other things we can either pick up now or raise issues for/
cmip7_attributes.py

  • further_info_url -
  • attributesValidator

further_info_url is discontinued as a required attribute in CMIP7, but it might be useful to point at one of the github repos under UKNCSP

attributesValidator -- we can develop this against the global attributes documentation at https://wcrp-cmip.github.io/cmip7-guidance/CMIP7/global_attributes/

cmip7_models.py

  • license

CMOR is handling licenses differently now; I think if you provide "license_id": "CC-BY 4.0" to CMOR it will construct the license text from the CVs and the institution id

Have updated the license and raised #671 and #672 for the other two points.

Tests should hopefully passing now after updating the import in plugin_loader.py

Copy link
Collaborator

@matthew-mizielinski matthew-mizielinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests are passing

@mo-jareddrayton mo-jareddrayton merged commit 574dd77 into main Nov 5, 2025
1 check passed
@mo-jareddrayton mo-jareddrayton deleted the 668-cmip7-replace-any-cmip6-references-in-the-cmip7-project-plugin branch November 18, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants