-
Notifications
You must be signed in to change notification settings - Fork 4
668 CMIP7: replace any cmip6 references in the cmip7 project plugin #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
668 CMIP7: replace any cmip6 references in the cmip7 project plugin #669
Conversation
CMOR is handling licenses differently now; I think if you provide |
matthew-mizielinski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
matthew-mizielinski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to fix the import in cdds/cdds/common/plugins/plugin_loader.py otherwise everything fails
Have updated the license and raised #671 and #672 for the other two points. Tests should hopefully passing now after updating the import in |
matthew-mizielinski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests are passing
This addresses #668
A few other things we can either pick up now or raise issues for/
cmip7_attributes.py
cmip7_models.py