Skip to content

#844: Test run UKESM1-3-LL#845

Merged
Lauren Boon (mo-laurenboon) merged 9 commits intomainfrom
844_test_run_UKESM1-3
Mar 25, 2026
Merged

#844: Test run UKESM1-3-LL#845
Lauren Boon (mo-laurenboon) merged 9 commits intomainfrom
844_test_run_UKESM1-3

Conversation

@mo-laurenboon
Copy link
Collaborator

Closes issue #844

Copy link
Collaborator

@matthew-mizielinski Matthew Mizielinski (matthew-mizielinski) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaks to model config file look fine, the change to the mapping looks inconsistent with the mapping issues.

@mo-laurenboon
Copy link
Collaborator Author

Note: I don't believe I have implemented this unit correctly as the error: ValueError: [UT_UNKNOWN] Failed to parse unit "DOBSON_UNIT_TO_METRES" is being triggered. I have traced the source back to the Unit class in /cf_units/init.py but cannot seem to find the source of what is considered to be a "valid unit" in order to add the new constant.

@mo-laurenboon
Copy link
Collaborator Author

Tests pass other than those marked -slow due to scheduled maintenance

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mo-laurenboon Lauren Boon (mo-laurenboon) merged commit 8ed54ae into main Mar 25, 2026
1 check passed
@mo-laurenboon Lauren Boon (mo-laurenboon) deleted the 844_test_run_UKESM1-3 branch March 25, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants