Skip to content

Conversation

@dasha-shchep
Copy link
Contributor

@dasha-shchep dasha-shchep commented Jan 10, 2024

Closes #107.

PR creation checklist for the developer

  • Does the feature branch name follow the format <issue_number>_<short_description_of_feature>?
  • Does the PR title exactly match with the issue title?
  • Have appropriate reviewers been added to the PR (once it is ready for review)?
  • Has the PR been assigned to the developer?
  • Has the Climate Model Evaluation Workflow (CMEW) project been added to the PR?
  • Has the appropriate milestone been added to the PR?

Definition of Done for the developer

  • Does the change in this PR address the above issue / have all acceptance criteria been met?
  • Does the change in this PR follow the recommendations in the wiki: Developer Guide?
  • Have new tests related to the change been added?
  • Do all the GitHub workflow checks pass?
  • Do all the tests run locally and pass? (Note: the tests are not run by the GitHub workflow, see wiki: Run the tests locally)
  • Has the API documentation related to the change been updated appropriately?
  • Has the user documentation related to the change been updated appropriately?
  • Do the HTML pages render correctly? (See wiki: Build the documentation locally)
  • Do the steps in the Quick Start section of the documentation work?

PR creation checklist for the reviewer

  • Does the feature branch name follow the format <issue_number>_<short_description_of_feature>?
  • Does the PR title exactly match with the issue title?
  • Have appropriate reviewers been added to the PR (once it is ready for review)?
  • Has the PR been assigned to the developer?
  • Has the Climate Model Evaluation Workflow (CMEW) project been added to the PR?
  • Has the appropriate milestone been added to the PR?

Definition of Done for the reviewer

  • Does the change in this PR address the above issue / have all acceptance criteria been met?
  • Does the change in this PR follow the recommendations in the wiki: Developer Guide?
  • Have new tests related to the change been added?
  • Do all the GitHub workflow checks pass?
  • Do all the tests run locally and pass? (Note: the tests are not run by the GitHub workflow, see wiki: Run the tests locally)
  • Has the API documentation related to the change been updated appropriately?
  • Has the user documentation related to the change been updated appropriately?
  • Do the HTML pages render correctly? (See wiki: Build the documentation locally)
  • Do the steps in the Quick Start section of the documentation work?

@dasha-shchep dasha-shchep added the configure Anything related to configuration label Jan 10, 2024
@dasha-shchep dasha-shchep added this to the v0.1.0 milestone Jan 10, 2024
@dasha-shchep dasha-shchep self-assigned this Jan 10, 2024
Copy link
Contributor

@mo-nabilbrice mo-nabilbrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change follows exactly from the Python API changelog in the ESMValTool documentation.

The configure_process test is now passing.

Copy link
Member

@ehogan ehogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this bug @dasha-shchep! 🥳

I would be happy for you to tick the adding / updating any new tests / documentation boxes, since the current tests cover this change, and there are no related documentation changes 😊

Please also mark this PR as "Ready for review" so it can be merged 😊

I also wanted to add explicitly to this PR that the process_radiation_budget task now fails, but this issue will be addressed via #114.

@dasha-shchep dasha-shchep marked this pull request as ready for review January 10, 2024 11:55
@dasha-shchep dasha-shchep merged commit ab058b3 into main Jan 10, 2024
@dasha-shchep dasha-shchep deleted the 107_fix_config_issue branch January 10, 2024 11:57
@ehogan ehogan mentioned this pull request Jan 11, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configure Anything related to configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix config issue

4 participants