Skip to content

Conversation

@dasha-shchep
Copy link
Contributor

@dasha-shchep dasha-shchep commented Jan 11, 2024

Closes #124.

PR creation checklist for the developer

  • Does the feature branch name follow the format <issue_number>_<short_description_of_feature>?
  • Does the PR title exactly match with the issue title?
  • Have appropriate reviewers been added to the PR (once it is ready for review)?
  • Has the PR been assigned to the developer?
  • Has the Climate Model Evaluation Workflow (CMEW) project been added to the PR?
  • Has the appropriate milestone been added to the PR?

Definition of Done for the developer

  • Does the change in this PR address the above issue / have all acceptance criteria been met?
  • Does the change in this PR follow the recommendations in the wiki: Developer Guide?
  • Have new tests related to the change been added?
  • Do all the GitHub workflow checks pass?
  • Do all the tests run locally and pass? (Note: the tests are not run by the GitHub workflow, see wiki: Run the tests locally)
  • Has the API documentation related to the change been updated appropriately?
  • Has the user documentation related to the change been updated appropriately?
  • Do the HTML pages render correctly? (See wiki: Build the documentation locally)
  • Do the steps in the Quick Start section of the documentation work?

PR creation checklist for the reviewer

  • Does the feature branch name follow the format <issue_number>_<short_description_of_feature>?
  • Does the PR title exactly match with the issue title?
  • Have appropriate reviewers been added to the PR (once it is ready for review)?
  • Has the PR been assigned to the developer?
  • Has the Climate Model Evaluation Workflow (CMEW) project been added to the PR?
  • Has the appropriate milestone been added to the PR?

Definition of Done for the reviewer

  • Does the change in this PR address the above issue / have all acceptance criteria been met?
  • Does the change in this PR follow the recommendations in the wiki: Developer Guide?
  • Have new tests related to the change been added?
  • Do all the GitHub workflow checks pass?
  • Do all the tests run locally and pass? (Note: the tests are not run by the GitHub workflow, see wiki: Run the tests locally)
  • Has the API documentation related to the change been updated appropriately?
  • Has the user documentation related to the change been updated appropriately?
  • Do the HTML pages render correctly? (See wiki: Build the documentation locally)
  • Do the steps in the Quick Start section of the documentation work?

@dasha-shchep dasha-shchep added the documentation Improvements or additions to documentation label Jan 11, 2024
@dasha-shchep dasha-shchep added this to the v0.1.0 milestone Jan 11, 2024
@dasha-shchep dasha-shchep self-assigned this Jan 11, 2024
@dasha-shchep dasha-shchep requested review from chrisbillowsMO and removed request for mo-gill January 12, 2024 10:45
Copy link
Contributor

@chrisbillowsMO chrisbillowsMO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks TREE-mendous to me! 🌲🌳🤩

Copy link
Member

@ehogan ehogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reporting and fixing this issue @dasha-shchep! 🥳

@dasha-shchep dasha-shchep merged commit 90f949b into main Jan 12, 2024
@dasha-shchep dasha-shchep deleted the 124_broken_link_in_README branch January 12, 2024 11:56
@dasha-shchep dasha-shchep changed the title Broken link in README #124 Broken link in README Jan 12, 2024
@dasha-shchep dasha-shchep changed the title #124 Broken link in README Broken link in README Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken link in README

4 participants