Skip to content

Enable user to specify CMIP runs in addition to model development runs#358

Merged
NParsonsMO merged 45 commits intomainfrom
130-add-cmip-runs-in-addition-using-rose-sections
Feb 24, 2026
Merged

Enable user to specify CMIP runs in addition to model development runs#358
NParsonsMO merged 45 commits intomainfrom
130-add-cmip-runs-in-addition-using-rose-sections

Conversation

@NParsonsMO
Copy link
Collaborator

@NParsonsMO NParsonsMO commented Feb 4, 2026 •
edited by mo-nikosbaltas
Loading

Closes #130.

PR creation checklist for the developer

  • Has <issue_number> above ☝️ been replaced with the issue number?
  • Has main been selected as the base branch?
  • Does the feature branch name follow the format <issue_number>_<short_description_of_feature>?
  • Does the text of the PR title exactly match with the text (not including the issue number) of the issue title?
  • Have appropriate reviewers been added to the PR (once it is ready for review)?
  • Has the PR been assigned to the developer(s)?
  • Have the same labels as on the issue (except for the good first issue label) been added to the PR?
    I didn't add the user story one either.
  • Has the Climate Model Evaluation Workflow (CMEW) project been added to the PR?
  • Has the appropriate milestone been added to the PR?

Definition of Done for the developer

  • Does the change in this PR address the above issue / have all acceptance criteria been met?
  • Does the change in this PR follow the requirements in the wiki: Developer Guide (including copyrights)?
  • Have new tests related to the change been added?
  • Do all the GitHub workflow checks pass?
  • Do all the tests run locally and pass? (Note: the tests are not run by the GitHub workflow, see wiki: Run the tests locally)
  • Has the API documentation (e.g. docstrings in Python modules) related to the change been updated appropriately?
  • Has the user documentation (i.e. everything in the doc directory) related to the change been updated appropriately, including the Quick Start section?
  • Do the HTML pages render correctly? (See wiki: Build the documentation locally)

PR creation checklist for the reviewer

  • Has <issue_number> above ☝️ been replaced with the issue number?
  • Has main been selected as the base branch?
  • Does the feature branch name follow the format <issue_number>_<short_description_of_feature>?
  • Does the text of the PR title exactly match with the text (not including the issue number) of the issue title?
  • Have appropriate reviewers been added to the PR (once it is ready for review)?
  • Has the PR been assigned to the developer(s)?
  • Have the same labels as on the issue (except for the good first issue label) been added to the PR?
  • Has the Climate Model Evaluation Workflow (CMEW) project been added to the PR?
  • Has the appropriate milestone been added to the PR?

Definition of Done for the reviewer

  • Does the change in this PR address the above issue / have all acceptance criteria been met?
  • Does the change in this PR follow the requirements in the wiki: Developer Guide (including copyrights)?
  • Have new tests related to the change been added?
  • Do all the GitHub workflow checks pass?
  • Do all the tests run locally and pass? (Note: the tests are not run by the GitHub workflow, see wiki: Run the tests locally)
  • Has the API documentation (e.g. docstrings in Python modules) related to the change been updated appropriately?
  • Has the user documentation (i.e. everything in the doc directory) related to the change been updated appropriately, including the Quick Start section?
  • Do the HTML pages render correctly? (See wiki: Build the documentation locally)

@NParsonsMO NParsonsMO linked an issue Feb 4, 2026 that may be closed by this pull request
Enable user to specify CMIP runs in addition to model development runs #130
Closed
@NParsonsMO NParsonsMO changed the title 130 add cmip runs in addition using rose sections Enable user to specify CMIP runs in addition to model development runs Feb 4, 2026
NParsonsMO
NParsonsMO commented Feb 10, 2026
View reviewed changes
CMEW/app/add_datasets/bin/add_datasets_to_share.py Outdated
write_dict_to_yaml(datasets, target_fp)


def dict_namelists_in_grandparent_dir():
Copy link
Collaborator Author

@NParsonsMO NParsonsMO Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider whether this comment is relevant to the current approach:
#349 (comment)

NParsonsMO
NParsonsMO commented Feb 11, 2026
View reviewed changes
CMEW/app/add_datasets/bin/test_add_datasets_to_share.py
Copy link
Collaborator Author

@NParsonsMO NParsonsMO Feb 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to copy the style from test_update_recipe_file.py, but wasn't really sure what I was doing, so maybe this is not great...

@NParsonsMO NParsonsMO added the standardise Anything related to CDDS label Feb 11, 2026
NParsonsMO
NParsonsMO commented Feb 13, 2026
View reviewed changes
CMEW/app/configure_for/bin/update_recipe_file.py
write_recipe(updated_recipe, recipe_path)

# Add the CMIP6 datasets to the recipe
cmip6_datasets_fp = f"{os.environ['DATASETS_LIST_DIR']}/cmip6_datasets.yml"
Copy link
Collaborator Author

@NParsonsMO NParsonsMO Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is made by rose even if there are no datasets in it

NParsonsMO
NParsonsMO commented Feb 13, 2026
View reviewed changes
CMEW/app/add_datasets/rose-app.conf
Copy link
Collaborator Author

@NParsonsMO NParsonsMO Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to put START_YEAR and NUMBER_OF_YEARS in here instead of the main rose-suite.conf, but currently it's needed there for the main model runs and it would be confusing to have it twice.

@NParsonsMO NParsonsMO marked this pull request as ready for review February 13, 2026 15:45
@zmaalick zmaalick self-requested a review February 13, 2026 16:02
@mo-nikosbaltas mo-nikosbaltas self-requested a review February 13, 2026 16:24
@NParsonsMO
Copy link
Collaborator Author

NParsonsMO commented Feb 17, 2026

This comment details something I want to discuss with reviewers.

mo-nikosbaltas
mo-nikosbaltas approved these changes Feb 24, 2026
View reviewed changes
Copy link
Collaborator

@mo-nikosbaltas mo-nikosbaltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added extra CMIP models and everything run successfully, including tests. Acceptance criteria have been fulfilled. It is all good to go.

zmaalick
zmaalick approved these changes Feb 24, 2026
View reviewed changes
Copy link
Collaborator

@zmaalick zmaalick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all work fine.

@NParsonsMO NParsonsMO merged commit 69cb092 into main Feb 24, 2026
3 checks passed
@NParsonsMO NParsonsMO deleted the 130-add-cmip-runs-in-addition-using-rose-sections branch February 24, 2026 16:33
@NParsonsMO NParsonsMO mentioned this pull request Feb 25, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmaalick zmaalick zmaalick approved these changes

@mo-nikosbaltas mo-nikosbaltas mo-nikosbaltas approved these changes

Assignees

@NParsonsMO NParsonsMO

Labels

standardise Anything related to CDDS

Projects

None yet

Milestone

v0.2.0 (multiple model runs)

Development

Successfully merging this pull request may close these issues.

Enable user to specify CMIP runs in addition to model development runs

3 participants

@NParsonsMO @zmaalick @mo-nikosbaltas