Skip to content

Reformat model runs.yml#388

Merged
Naomi Parsons (NParsonsMO) merged 7 commits intomainfrom
383-reformat-model_runsyml
Mar 5, 2026
Merged

Reformat model runs.yml#388
Naomi Parsons (NParsonsMO) merged 7 commits intomainfrom
383-reformat-model_runsyml

Conversation

@NParsonsMO
Copy link
Copy Markdown
Collaborator

@NParsonsMO Naomi Parsons (NParsonsMO) commented Feb 26, 2026 •
edited by zmaalick
Loading

Closes #383.
Also closes #386.

PR creation checklist for the developer

  • The <issue_number> above ☝️ has been replaced with the issue number.
  • main has been selected as the base branch.
  • The feature branch name follows the format <issue_number>_<short_description_of_feature>.
  • The text of the PR title exactly matches with the text (not including the issue number) of the issue title.
  • Appropriate reviewers have been added to the PR (once it is ready for review).
  • The PR has been assigned to the developer(s).
  • The same labels as on the issue (except for the good first issue label) have been added to the PR.
  • The Climate Model Evaluation Workflow (CMEW) project has been added to the PR.
  • The appropriate milestone has been added to the PR.

Definition of Done for the developer

  • The change in this PR addresses the above issue / all acceptance criteria have been met.
  • The change in this PR follows the requirements in the wiki: Developer Guide (including copyrights).
  • The GitHub Actions workflow checks pass.
  • The tests run locally and pass (Note: the tests are not run by the GitHub Actions workflow, see wiki: Run the tests locally).
  • Updating the Rose metadata (select one of the following):
    • Rose metadata related to the change has been added or updated.
    • The change does not require Rose metadata to be added or updated.
  • Rendering the Rose metadata (select one of the following):
    • The Rose GUI shows the change as expected.
    • The change in this PR does not affect the Rose GUI.
  • Updating the tests (select one of the following):
    • Tests related to the change have been added or updated.
    • The change does not require tests to be added or updated.
  • Updating the user documentation (i.e. everything in the doc directory, including the Quick Start section; select one of the following):
    • The user documentation related to the change has been updated appropriately.
    • The change in this PR does not require the user documentation to be updated.
  • Rendering the user documentation (wiki: Build the documentation locally provides instructions; select one of the following):
    • The HTML pages show the change as expected.
    • The change in this PR does not affect the HTML pages.
  • Updating the API documentation (e.g. docstrings in Python modules; select one of the following):
    • The API documentation related to the change has been updated appropriately.
    • The change in this PR does not affect the API documentation.

PR creation checklist for the reviewer

  • The <issue_number> above ☝️ has been replaced with the issue number.
  • main has been selected as the base branch.
  • The feature branch name follows the format <issue_number>_<short_description_of_feature>.
  • The text of the PR title exactly matches with the text (not including the issue number) of the issue title.
  • Appropriate reviewers have been added to the PR (once it is ready for review).
  • The PR has been assigned to the developer(s).
  • The same labels as on the issue (except for the good first issue label) have been added to the PR.
  • The Climate Model Evaluation Workflow (CMEW) project has been added to the PR.
  • The appropriate milestone has been added to the PR.

Definition of Done for the reviewer

  • The change in this PR addresses the above issue / all acceptance criteria have been met.
  • The change in this PR follows the requirements in the wiki: Developer Guide (including copyrights).
  • The GitHub Actions workflow checks pass.
  • The tests run locally and pass (Note: the tests are not run by the GitHub Actions workflow, see wiki: Run the tests locally).
  • Updating the Rose metadata (select one of the following):
    • Rose metadata related to the change has been added or updated.
    • The change does not require Rose metadata to be added or updated.
  • Rendering the Rose metadata (select one of the following):
    • The Rose GUI shows the change as expected.
    • The change in this PR does not affect the Rose GUI.
  • Updating the tests (select one of the following):
    • Tests related to the change have been added or updated.
    • The change does not require tests to be added or updated.
  • Updating the user documentation (i.e. everything in the doc directory, including the Quick Start section; select one of the following):
    • The user documentation related to the change has been updated appropriately.
    • The change in this PR does not require the user documentation to be updated.
  • Rendering the user documentation (wiki: Build the documentation locally provides instructions; select one of the following):
    • The HTML pages show the change as expected.
    • The change in this PR does not affect the HTML pages.
  • Updating the API documentation (e.g. docstrings in Python modules; select one of the following):
    • The API documentation related to the change has been updated appropriately.
    • The change in this PR does not affect the API documentation.

Important

  • Remember to re-check the Definition of Done after making changes in response to a review.
  • The developer merges the PR.
  • Remember to use the format #<pull_request_number>: <pull_request_title> when writing the merge commit message for the pull request, so the pull request number is immediately visible on GitHub, regardless of the length of the pull request title.

@NParsonsMO Naomi Parsons (NParsonsMO) linked an issue Feb 26, 2026 that may be closed by this pull request
Reformat model_runs.yml #383
Closed
NParsonsMO
Naomi Parsons (NParsonsMO) commented Feb 26, 2026
View reviewed changes
Comment thread CMEW/app/add_datasets/bin/test_add_datasets_to_share.py
assert actual == expected


# This one was only *some* random copying of Google
Copy link
Copy Markdown
Collaborator Author

@NParsonsMO Naomi Parsons (NParsonsMO) Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a line I'd meant to remove last time

@NParsonsMO Naomi Parsons (NParsonsMO) marked this pull request as ready for review February 26, 2026 15:51
@NParsonsMO
Copy link
Copy Markdown
Collaborator Author

Naomi Parsons (NParsonsMO) commented Feb 26, 2026 •
edited
Loading

Maybe we want to reformat both yamls, for consistency, Emma Hogan (@ehogan)?

NParsonsMO
Naomi Parsons (NParsonsMO) commented Feb 26, 2026
View reviewed changes
Comment thread CMEW/app/add_datasets/bin/add_datasets_to_share.py
return filepaths


def use_facet_as_key(filepath, key_facet="suite_id"):
Copy link
Copy Markdown
Collaborator Author

@NParsonsMO Naomi Parsons (NParsonsMO) Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think that setting this default is the best way?

Copy link
Copy Markdown
Collaborator

@zmaalick Zubair Maalick (zmaalick) Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine.

@zmaalick
Copy link
Copy Markdown
Collaborator

Zubair Maalick (zmaalick) commented Mar 2, 2026

Please add appropriate label and milestones

@NParsonsMO
Copy link
Copy Markdown
Collaborator Author

Naomi Parsons (NParsonsMO) commented Mar 3, 2026

Please add appropriate label and milestones

I've added the 0.2.0 milestone, as I assume that's the right one. but I don't know what labels are meant to be here - there aren't any on the issue (it didn't go through refinement).

zmaalick
Zubair Maalick (zmaalick) approved these changes Mar 3, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@zmaalick Zubair Maalick (zmaalick) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. All fine, do not have any recommendation. approving.

Comment thread CMEW/app/add_datasets/bin/add_datasets_to_share.py
return filepaths


def use_facet_as_key(filepath, key_facet="suite_id"):
Copy link
Copy Markdown
Collaborator

@zmaalick Zubair Maalick (zmaalick) Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine.

@mo-nikosbaltas mo-nikosbaltas self-requested a review March 5, 2026 12:12
mo-nikosbaltas
mo-nikosbaltas approved these changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mo-nikosbaltas mo-nikosbaltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes fulfilled ACs and tests passed successfully. No changes are required. Good to go.

@NParsonsMO Naomi Parsons (NParsonsMO) merged commit 8356671 into main Mar 5, 2026
3 checks passed
@NParsonsMO Naomi Parsons (NParsonsMO) deleted the 383-reformat-model_runsyml branch March 5, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmaalick Zubair Maalick (zmaalick) zmaalick approved these changes

+1 more reviewer

@mo-nikosbaltas mo-nikosbaltas mo-nikosbaltas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NParsonsMO Naomi Parsons (NParsonsMO)

Labels

None yet

Projects

None yet

Milestone

v0.2.0 (multiple model runs)

Development

Successfully merging this pull request may close these issues.

Remove accidental line Reformat model_runs.yml

3 participants

@NParsonsMO @zmaalick @mo-nikosbaltas