Skip to content

Fix checkbox formatting in PR template #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jon-Lillis merged 1 commit into from
Feb 24, 2023
Merged

Fix checkbox formatting in PR template #45

Jon-Lillis merged 1 commit into from
Feb 24, 2023

Conversation

@Jon-Lillis
Copy link
Collaborator

@Jon-Lillis Jon-Lillis commented Feb 24, 2023 •
edited by mo-tgeddes
Loading

Closes #44.

PR creation checklist

  • Does the feature branch name follow the format <issue_number>_<short_description_of_feature>?
  • Does the PR title exactly match with the issue title?
  • Have appropriate reviewers been added to the PR?
  • Has the PR been assigned to the developer?
  • Has the Climate Model Evaluation Workflow (CMEW) project been added to the PR?
  • Has the appropriate milestone been added to the PR?

Review checklist

  • Do the changes in this PR address the above issue / have all acceptance criteria been met?
  • Do the changes follow the recommendations in the wiki: Developer Guide?
  • Do all the tests pass? (the tests are not run by the GitHub workflow)
  • Has the documentation been updated appropriately?
  • Do the HTML pages render correctly?
  • Do the steps in the "Quick Start" section work?

@Jon-Lillis Jon-Lillis self-assigned this Feb 24, 2023
@Jon-Lillis Jon-Lillis added this to the v0.1.0 milestone Feb 24, 2023
mo-tgeddes
mo-tgeddes approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@mo-tgeddes mo-tgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@Jon-Lillis Jon-Lillis merged commit 364f7f7 into main Feb 24, 2023
@Jon-Lillis Jon-Lillis deleted the 44_pr_checkboxes branch February 24, 2023 10:17
@ehogan ehogan added bug Something isn't working quality assurance Anything related to Quality Assurance (QA) labels Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mo-tgeddes mo-tgeddes mo-tgeddes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Jon-Lillis Jon-Lillis

Labels

bug Something isn't working quality assurance Anything related to Quality Assurance (QA)

Projects

None yet

Milestone

v0.1.0 (single recipe)

Development

Successfully merging this pull request may close these issues.

Fix checkbox formatting in PR template

4 participants

@Jon-Lillis @mo-tgeddes @ehogan