-
Notifications
You must be signed in to change notification settings - Fork 1
Rename CAW to CMEW #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jon-Lillis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blimey, there were loads of references to CAW! Thanks for catching so many.
To review this issue, I checked out your branch and did a quick search myself to make sure that there was nothing left and I think I've found a few more.
.github/workflowsnow creates thecmew.lockfile, but the environment is still calledcaw.rose-app.confstill refers to the environment ascaw-env.install_cold.shalso refers tocaw-env.doc/source/about.rststarts with 'Climate Assessment Workflow'.doc/source/user_guide/quick_start.rstrefers to theclimate-assessment-workflowrepository. These instructions should be updated to use the renamed CMEW repository and tested to ensure they're compatible with the rest of your renaming updates.
I think that's all I've found to have slipped through the cracks. Once you've addressed these last updates, I think this should be good to go!
|
Looks like you're close Amanda, but be careful with the documentation. The repository is called 'CMEW' rather than 'climate-model-evaluation-workflow', so your updated instructions for cloning the repository won't work. Be sure to give them a test run! |
|
Yep, that's right :) |
Jon-Lillis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Thanks Amanda! The new directory structure looks good, there doesn't seem to be any remaining references to the CAW, and all tests still pass and the docs continue to build. Good job!
Closes #26.
PR creation checklist
<issue_number>_<short_description_of_feature>?Climate Model Evaluation Workflow (CMEW)project been added to the PR?Review checklist