Skip to content

Conversation

@amanda87x
Copy link
Contributor

@amanda87x amanda87x commented Mar 2, 2023

Closes #26.

PR creation checklist

  • Does the feature branch name follow the format <issue_number>_<short_description_of_feature>?
  • Does the PR title exactly match with the issue title?
  • Have appropriate reviewers been added to the PR?
  • Has the PR been assigned to the developer?
  • Has the Climate Model Evaluation Workflow (CMEW) project been added to the PR?
  • Has the appropriate milestone been added to the PR?

Review checklist

  • Do the changes in this PR address the above issue / have all acceptance criteria been met?
  • Do the changes follow the recommendations in the wiki: Developer Guide?
  • Do all the tests pass? (the tests are not run by the GitHub workflow)
  • Has the documentation been updated appropriately?
  • Do the HTML pages render correctly?
  • Do the steps in the "Quick Start" section work?

@amanda87x amanda87x requested a review from Jon-Lillis March 2, 2023 12:31
@amanda87x amanda87x changed the title Renaming CAW to CMEW #26 Renaming CAW to CMEW Mar 2, 2023
Copy link
Collaborator

@Jon-Lillis Jon-Lillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blimey, there were loads of references to CAW! Thanks for catching so many.

To review this issue, I checked out your branch and did a quick search myself to make sure that there was nothing left and I think I've found a few more.

  • .github/workflows now creates the cmew.lock file, but the environment is still called caw.
  • rose-app.conf still refers to the environment as caw-env.
  • install_cold.sh also refers to caw-env.
  • doc/source/about.rst starts with 'Climate Assessment Workflow'.
  • doc/source/user_guide/quick_start.rst refers to the climate-assessment-workflow repository. These instructions should be updated to use the renamed CMEW repository and tested to ensure they're compatible with the rest of your renaming updates.

I think that's all I've found to have slipped through the cracks. Once you've addressed these last updates, I think this should be good to go!

@Jon-Lillis
Copy link
Collaborator

Looks like you're close Amanda, but be careful with the documentation. The repository is called 'CMEW' rather than 'climate-model-evaluation-workflow', so your updated instructions for cloning the repository won't work. Be sure to give them a test run!

@amanda87x
Copy link
Contributor Author

Looks like you're close Amanda, but be careful with the documentation. The repository is called 'CMEW' rather than 'climate-model-evaluation-workflow', so your updated instructions for cloning the repository won't work. Be sure to give them a test run!
Do you mean it should be git clone git@github.com:MetOffice/CMEW.git?

@Jon-Lillis
Copy link
Collaborator

Jon-Lillis commented Mar 9, 2023

Do you mean it should be git clone git@github.com:MetOffice/CMEW.git?

Yep, that's right :)

@Jon-Lillis Jon-Lillis self-requested a review March 10, 2023 10:50
Copy link
Collaborator

@Jon-Lillis Jon-Lillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks Amanda! The new directory structure looks good, there doesn't seem to be any remaining references to the CAW, and all tests still pass and the docs continue to build. Good job!

@amanda87x amanda87x merged commit b924ab7 into main Mar 10, 2023
@amanda87x amanda87x deleted the 26_renaming_CAW_CMEW branch March 10, 2023 11:16
@ehogan ehogan added this to the v0.1.0 milestone Mar 20, 2023
@ehogan ehogan changed the title Renaming CAW to CMEW Rename CAW to CMEW Mar 20, 2023
@ehogan ehogan mentioned this pull request Apr 3, 2023
ehogan added a commit that referenced this pull request Apr 6, 2023
@ehogan ehogan mentioned this pull request Apr 12, 2023
12 tasks
ehogan added a commit that referenced this pull request May 10, 2023
* Revert "Renaming CAW to CMEW (#47)"

This reverts commit b924ab7.

* #78: Restore a missed CMEW to CAW

* #78: Remove trailing whitespace
This was referenced May 10, 2023
ehogan added a commit that referenced this pull request Jul 17, 2023
* main:
  #98: Rename CAW to CMEW
  #97: Rename the workflow directory
  #88: Revert "Renaming CAW to CMEW (#47)"
  #72: Create a checkout_standardise task
  Rename the site/metoffice-env environment file (#69)
  Update CMEW to use ESMValTool v2.7.0 (#70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename CAW to CMEW

4 participants