Add special handling for Paths in replace_template_variable #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
daflack
approved these changes
Aug 12, 2025
Contributor
daflack
left a comment
daflack
left a comment
There was a problem hiding this comment.
Looks good to me, one comment (mainly from a curiosity perspective)
This allows Path objects to be formatted correctly when serialised, such as when parbaking a recipe.
jfrost-mo
force-pushed
the
replace_template_variables_paths
branch
from
34c47b3 to
943ef49
Compare
Member
Author
|
Conflict resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Path objects to be formatted correctly when serialised, such as when parbaking a recipe.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.