Skip to content

Conversation

@jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Aug 26, 2025

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jfrost-mo jfrost-mo self-assigned this Aug 26, 2025
@jfrost-mo jfrost-mo added the enhancement New feature or request label Aug 26, 2025
Copy link
Contributor

@daflack daflack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable to me. I've not yet run it though. Also same comment applies as to part 2 - are the tests breakages a problem or are they fixed by later PRs?

@daflack
Copy link
Contributor

daflack commented Aug 28, 2025

Runs as expected.

@jfrost-mo
Copy link
Member Author

Tests have been fixed in #1635.

Base automatically changed from 837_part2_parbake_infrastructure to main September 1, 2025 10:51
@jfrost-mo jfrost-mo force-pushed the 837_part3_add_parbake_recipes branch from 455e2dd to 8d2714e Compare September 1, 2025 10:52
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Coverage

Copy link
Contributor

@daflack daflack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes, now tests pass.

@jfrost-mo jfrost-mo force-pushed the 837_part3_add_parbake_recipes branch from 8d2714e to 83a8972 Compare September 1, 2025 10:54
@jfrost-mo jfrost-mo merged commit 40c8449 into main Sep 1, 2025
8 checks passed
@jfrost-mo jfrost-mo deleted the 837_part3_add_parbake_recipes branch September 1, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants