Add presence of fog diagnostic #1771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traditionally fog is considered (by the public) as when the visibility reduces to less than 250 m. Fixes #1561
Contributor
|
|
daflack
requested review from
Sylviabohnenstengel,
mo-jthornton and
mo-sanamahmood
Contributor
Author
|
Spatial plot: timeseries: difference plot: |
mo-sanamahmood
requested changes
Oct 22, 2025
Contributor
mo-sanamahmood
left a comment
mo-sanamahmood
left a comment
There was a problem hiding this comment.
Just need to remove an extra 'a' in the description in src/CSET/recipes/derived_diagnostics/daily_weather/fog_presence_spatial_difference.yaml
src/CSET/recipes/derived_diagnostics/daily_weather/fog_presence_spatial_difference.yaml
Outdated
Show resolved
Hide resolved
daflack
commented
Oct 22, 2025
src/CSET/recipes/derived_diagnostics/daily_weather/fog_presence_spatial_difference.yaml
Outdated
Show resolved
Hide resolved
mo-sanamahmood
approved these changes
Oct 22, 2025
Contributor
mo-jthornton
left a comment
mo-jthornton
left a comment
There was a problem hiding this comment.
Looks good, but I'm a little confused by the threshold being < 250 m - is this based on what a particular customer (i.e. defence-related) wants or something to do with forecaster preference? I would consider fog to be vis<1km (according to the WMO definition).
Contributor
Author
|
More of a public definition of fog, rather than the aviation definition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traditionally fog is considered (by the public) as when the visibility reduces to less than 250 m. Adds in recipes for spatial plot, spatial differences, and domain mean time series.
Fixes #1561
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.