Skip to content

Creating diagnostic for reading observation from Cardington single point location#1890

Merged
James Frost (jfrost-mo) merged 31 commits intomainfrom
1750_2m_Cardington_air_temperature
Apr 1, 2026
Merged

Creating diagnostic for reading observation from Cardington single point location#1890
James Frost (jfrost-mo) merged 31 commits intomainfrom
1750_2m_Cardington_air_temperature

Conversation

@mo-jbrooke
Copy link
Copy Markdown
Contributor

@mo-jbrooke Jenn Brooke (mo-jbrooke) commented Jan 27, 2026

Adding CSET recipe and timeseries plot in loaders.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

…int location. Adding CSET recipe and timeseries plot in loaders.
@jfrost-mo James Frost (jfrost-mo) changed the title Creating diagnostic for reading observation from Cardington single po… Creating diagnostic for reading observation from Cardington single point location Feb 18, 2026
Copy link
Copy Markdown
Member

@jfrost-mo James Frost (jfrost-mo) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given a quick look over, and while there are a few things that need tidying up or testing it is overall looking very good.

Comment thread src/CSET/operators/read.py Outdated
Comment thread src/CSET/operators/regrid_old.py Outdated
Comment thread src/CSET/operators/regrid.py
Comment thread src/CSET/operators/regrid.py Outdated
Comment thread src/CSET/operators/plot.py
Comment thread src/CSET/operators/misc.py
Comment thread src/CSET/operators/read.py Outdated
Comment thread src/CSET/operators/read.py Outdated
Comment thread src/CSET/operators/constraints.py
Comment thread src/CSET/operators/misc.py
Comment thread src/CSET/cset_workflow/.nfs00000000195e8bee00000045 Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026

Coverage

Copy link
Copy Markdown
Member

@jfrost-mo James Frost (jfrost-mo) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look through the changes and they address all the identified issues.

A very minor comments on tidying some whitespace, and another on a small bug coming from existing code. I'll go ahead and fix them myself so this pull request can be merged.

Comment thread src/CSET/operators/regrid.py Outdated
Comment thread src/CSET/operators/regrid.py
@jfrost-mo James Frost (jfrost-mo) merged commit 977d7cc into main Apr 1, 2026
8 checks passed
@jfrost-mo James Frost (jfrost-mo) deleted the 1750_2m_Cardington_air_temperature branch April 1, 2026 14:27
@jfrost-mo
Copy link
Copy Markdown
Member

Simon Osborne (@mo-sro) all merged now! Thank you for getting this across the line. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants