Handle converting multiple wind cubes to point to true north#1892
Merged
Handle converting multiple wind cubes to point to true north#1892
Conversation
This avoids crashing when loading data with more than one of each wind component, such as an instantaneous and an aggregation cube. This was especially problematic as it runs in the callback stage, so it will crash even recipes that don't use the wind.
jfrost-mo
added
bug
Contributor
|
|
daflack
approved these changes
Feb 17, 2026
Collaborator
daflack
left a comment
daflack
left a comment
There was a problem hiding this comment.
Happy with these changes, look sensible and will only likely error if we have a different number of u and v cubes, which we would not expect so is sensible to error on that. Happy that the tests don't need to be updated, and all tests past.
daflack
deleted the
handle_multiple_wind_fields_in_fix_um_winds_callback
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids crashing when loading data with more than one of each wind component, such as an instantaneous and an aggregation cube. This was especially problematic as it runs in the callback stage, so it will crash even recipes that don't use the wind.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.