Add relative gitignores for site specific files in workflow#1927
Merged
JorgeBornemann merged 1 commit intomainfrom Feb 24, 2026
Merged
Add relative gitignores for site specific files in workflow#1927JorgeBornemann merged 1 commit intomainfrom
JorgeBornemann merged 1 commit intomainfrom
Conversation
The previous attempt in c04f769 allows the app opt files to be included, but now doesn't exclude the top level workflow opt. To avoid this while still allowing app opt files, we now use an exclude pattern relative to the .gitignore file.
jfrost-mo
added
small
Contributor
|
|
JorgeBornemann
approved these changes
Feb 24, 2026
Collaborator
JorgeBornemann
left a comment
JorgeBornemann
left a comment
There was a problem hiding this comment.
Sorry, I missed the workflow optional configurations in the previous review, much better this way.
JorgeBornemann
deleted the
1924_gitignore_workflow_opt_but_not_app_opt
branch
Member
Author
|
OFFICIAL
So did I 😅
Definitely better now.
OFFICIAL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous attempt in c04f769 allows the app opt files to be included, but now doesn't exclude the top level workflow opt. To avoid this while still allowing app opt files, we now use an exclude pattern relative to the .gitignore file.
Fixes #1921 (but better.)
Follow up to #1924.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.