Skip to content

Adds missing entires in rose-suite.conf.example#1946

Merged
David Flack (daflack) merged 3 commits into
mainfrom
1944_rose_suite_conf_example_fix
Mar 6, 2026
Merged

Adds missing entires in rose-suite.conf.example#1946
David Flack (daflack) merged 3 commits into
mainfrom
1944_rose_suite_conf_example_fix

Conversation

@daflack
Copy link
Copy Markdown
Collaborator

Fixes #1944

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2026

Coverage

@daflack
Copy link
Copy Markdown
Collaborator Author

When I've opened rose edit with this rose-suite.conf file the only "red"/error section I have is the site selection - which we did not want to default anyway, otherwise all good from the diagnostics perspective:
image

Comment thread src/CSET/cset_workflow/rose-suite.conf.example
@daflack David Flack (daflack) added bug Something isn't working small Small issue that should be quick to resolve cleanup Non-functional improvement labels Mar 5, 2026
Copy link
Copy Markdown
Contributor

@ukmo-huw-lewis ukmo-huw-lewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes, and have independently checked the proposed rose-suite.example has the SITE 'red triangle' only now, thank you.

@ukmo-huw-lewis
Copy link
Copy Markdown
Contributor

Will leave David to mark conversation resolved and merge when ready.

Have thoughts on other aspects of GUI layout (can discuss), but propose those sit in different issue/PR.

@ukmo-huw-lewis
Copy link
Copy Markdown
Contributor

STOP PRESS: Please double check if SURFACE_SYNOP_OBS set True as default - should be set to False in example.

@daflack
Copy link
Copy Markdown
Collaborator Author

ukmo-huw-lewis thanks for the stop press, have checked and fixed accordingly - will resolve conversation and merge.

@daflack David Flack (daflack) merged commit 39361d9 into main Mar 6, 2026
8 checks passed
@daflack David Flack (daflack) deleted the 1944_rose_suite_conf_example_fix branch March 6, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup Non-functional improvement small Small issue that should be quick to resolve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconcistencies between rose-suite.conf_example and metadata

2 participants