Update read operator to catch erroneous grid bounds inputs#1953
Merged
David Flack (daflack) merged 5 commits intoMar 6, 2026
Merged
Conversation
Contributor
Author
|
Example REP test with change (left = before; right = after): 
|
ukmo-huw-lewis
changed the title
Contributor
|
|
Collaborator
David Flack (daflack)
left a comment
David Flack (daflack)
left a comment
There was a problem hiding this comment.
Looks good. One quick question, and one suggestion to separate the test into two; otherwise happy.
split out new tests
David Flack (daflack)
approved these changes
Mar 6, 2026
Collaborator
David Flack (daflack)
left a comment
David Flack (daflack)
left a comment
There was a problem hiding this comment.
Happy with changes following review. Feel free to merge when ready.
David Flack (daflack)
deleted the
1952-catch-erroneous-grid-bounds-information-when-reading-cubes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.