Skip to content

Switch pressure level plots to use pcolormesh#1967

Merged
David Flack (daflack) merged 1 commit into
mainfrom
use_pcolormesh
Mar 13, 2026
Merged

Switch pressure level plots to use pcolormesh#1967
David Flack (daflack) merged 1 commit into
mainfrom
use_pcolormesh

Conversation

@jwarner8
Copy link
Copy Markdown
Contributor

@jwarner8 James Warner (jwarner8) commented Mar 12, 2026

Switches pressure level spatial plots to use pcolormesh rather than contourf, given shapely geos errors arising occasionally and reproducibly, likely due to issues with the contour polygons.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Ensure rose-suite.conf.example has been updated if new diagnostic added.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jwarner8
Copy link
Copy Markdown
Contributor Author

Links to #672 but doesn't solve.

@github-actions
Copy link
Copy Markdown
Contributor

Coverage

Copy link
Copy Markdown
Collaborator

@daflack David Flack (daflack) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with these changes.

@daflack David Flack (daflack) merged commit a6e0df2 into main Mar 13, 2026
8 checks passed
@daflack David Flack (daflack) deleted the use_pcolormesh branch March 13, 2026 08:48
@vinodk-bom
Copy link
Copy Markdown
Contributor

James Warner (@jwarner8) and David Flack (@daflack), note that this temporary fix may need to be extended to the sequence plotting and the case aggregation by mean validity time recipes as well. My workflow tripped at these two instances and worked when I applied pcolormesh instead of contour_plot.

https://github.com/MetOffice/CSET/blob/main/src/CSET/recipes/level_fields/generic_level_spatial_plot_sequence.yaml
https://github.com/MetOffice/CSET/blob/main/src/CSET/recipes/level_fields/generic_level_spatial_plot_sequence_case_aggregation_mean_validity_time.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Non-functional improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants