Adds differentiation operator#1979
Merged
Merged
Conversation
Contributor
|
|
David Flack (daflack)
changed the title
David Flack (daflack)
requested review from
Sylvia Bohnenstengel (Sylviabohnenstengel) and
ukmo-huw-lewis
James Frost (jfrost-mo)
approved these changes
Apr 8, 2026
Member
James Frost (jfrost-mo)
left a comment
James Frost (jfrost-mo)
left a comment
There was a problem hiding this comment.
Looks like a sensible operator; happy to approve.
I've left a small suggestion on adding an extra check, but I'm not 100% sure it wouldn't cause false positives, so I'll leave it up to you to decide on including it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple differentiation operator that acts as a wrapper around
iris.analysis.calculus.differentiate. Spherical coordinate differentiation is not possible with this operator.This is an enabling PR which will allow extreme rainfall diagnostics to be calculated, but will also allow be useful for other areas. No recipes are included as it is likely to form part of recipes in the future.
Fixes #1959
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.