Various improvements to transect capability#1992
Merged
Merged
Conversation
Contributor
Contributor
Author
Contributor
Author
|
Progress:
|
Contributor
Author
Contributor
Author
|
Now ready for review, note their are no new tests, as its not clear how we would test a transect inset (other than trying it for different use cases and visually inspecting the output). |
James Frost (jfrost-mo)
approved these changes
Apr 7, 2026
Member
James Frost (jfrost-mo)
left a comment
There was a problem hiding this comment.
Not run myself, but the code change looks good. A couple minor suggestions but it is up to you if you take them.
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
Contributor
Author
Thanks for the review, these suggestions sound sensible and have now implemented, will go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Broad collection of improvements to the transect capability in CSET, addressing the following issues/enhancement requests for pressure level transects;
Co-pilot was used to generate some of the code ideas used for the transect inset, which was further reviewed and adapted by JamesW.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.