Work around coverage issue with netcdf4 library#2009
Merged
Conversation
James Frost (jfrost-mo)
added
small
Contributor
|
|
Member
Author
|
Yep, that workaround works, as shown in #2010. |
James Warner (jwarner8)
approved these changes
Mar 31, 2026
Contributor
James Warner (jwarner8)
left a comment
James Warner (jwarner8)
left a comment
There was a problem hiding this comment.
Looks good to me, I imagine we'll need to review this occasionally once it is fixed and no longer need to omit.
Member
Author
|
Yep. I've subscribed to the relevant issue in the netcdf4 conda feedstock repository to keep an eye on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See conda-forge/netcdf4-feedstock#188
A more permanent workaround than manually reverting each update PR.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.