Skip to content

Revert "Skip rather than suicide bake task when there are no recipes"#2019

Merged
James Frost (jfrost-mo) merged 1 commit into
mainfrom
1993_revert_skipping_rather_than_suiciding
Apr 2, 2026
Merged

Revert "Skip rather than suicide bake task when there are no recipes"#2019
James Frost (jfrost-mo) merged 1 commit into
mainfrom
1993_revert_skipping_rather_than_suiciding

Conversation

@jfrost-mo
Copy link
Copy Markdown
Member

This reverts commit 9866e19.

Fixes #1993

Tested on a local workflow and sucessfully suicides the aggregation task when no jobs to run.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Ensure rose-suite.conf.example has been updated if new diagnostic added.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jfrost-mo James Frost (jfrost-mo) added the bug Something isn't working label Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

Coverage

@refszkentla
Copy link
Copy Markdown
Contributor

This version also works, no bake_aggregation is performed. I like it :) (even though the graph is slightly more complicated..)

@jfrost-mo James Frost (jfrost-mo) merged commit 564f911 into main Apr 2, 2026
8 checks passed
@jfrost-mo James Frost (jfrost-mo) deleted the 1993_revert_skipping_rather_than_suiciding branch April 2, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cylc broadcast blocking the aggregation recipes fails when remote connection is only one directional

2 participants