Include full path in filename for linked filesystem files#2022
Merged
Conversation
The path separator is replaced with a ")", which should be fairly clear in most cases, and isn't generally a restricted character on filesystems. By doing this we are able to handle files from different directories with the same name. Fixes #1939
James Frost (jfrost-mo)
added
bug
James Frost (jfrost-mo)
requested review from
Stephen Gallagher (SGallagherMet) and
mo-tomosevans
Contributor
|
|
Stephen Gallagher (SGallagherMet)
requested changes
Apr 2, 2026
Contributor
Stephen Gallagher (SGallagherMet)
left a comment
Stephen Gallagher (SGallagherMet)
left a comment
There was a problem hiding this comment.
Looks good. I'd like the comment to explain why the ) character is being used but other than that just a small suggestion.
Stephen Gallagher (SGallagherMet)
requested changes
Apr 2, 2026
James Frost (jfrost-mo)
requested a review
from Stephen Gallagher (SGallagherMet)
Stephen Gallagher (SGallagherMet)
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path separator is replaced with a
), which should be fairly clear in most cases, and isn't generally a restricted character on filesystems.By doing this we are able to handle files from different directories with the same name.
Fixes #1939
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.