Support transect difference plotting and aggregation#2026
Merged
Conversation
Contributor
Contributor
Author
Contributor
Author
|
Now much better, likely linked to #1535 too (threaded through for all transect recipes). |
Contributor
Author
Contributor
Author
|
TODO
Tests required...
|
8 tasks
Collaborator
David Flack (daflack)
left a comment
There was a problem hiding this comment.
Looking good, one typo and requests for some more testing.
- Can we get a test(s) that cover line 309-312 in
misc.pycurrently all tests skip these lines. - Can we increase coverage in
transect.py- needs tests for L136 (if statement false), L165 - to test the exception works, and L174 is currently always true - if expected can be an else, if not and something happens (even if yet to be implemented) when statement is false can this be tested as well please.
Haven't run it yet, but otherwise is looking great.
Co-authored-by: David Flack <77390156+daflack@users.noreply.github.com>
Contributor
Author
|
Contributor
Author
Contributor
Author
|
Test coverage now 100% for |
David Flack (daflack)
approved these changes
Apr 15, 2026
Collaborator
David Flack (daflack)
left a comment
There was a problem hiding this comment.
Happy with these changes, thanks for adding the extra tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Addresses #2025
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.