Correctly handle scalar coords in aggregated cubes#2027
Merged
James Frost (jfrost-mo) merged 1 commit intoApr 13, 2026
Conversation
James Frost (jfrost-mo)
force-pushed
the
2023_improve_aggregation_reliability
branch
from
4be567a to
250ea8d
Compare
Contributor
|
|
James Frost (jfrost-mo)
requested a review
from Stephen Gallagher (SGallagherMet)
Contributor
Stephen Gallagher (SGallagherMet)
left a comment
Stephen Gallagher (SGallagherMet)
left a comment
There was a problem hiding this comment.
These changes look fine, but I'd like mo-tomosevans to try them on the data that caused the issues before the PR is approved.
mo-tomosevans
approved these changes
Apr 13, 2026
mo-tomosevans
left a comment
mo-tomosevans
left a comment
There was a problem hiding this comment.
Just produced the plots below for MOGREPS-UK trial data, so the changes look good to go for me!
This opens up the aggregation recipes to support aggregating across single values, which while theoretically useless ensures that aggregation can remain enabled across varied data.
James Frost (jfrost-mo)
force-pushed
the
2023_improve_aggregation_reliability
branch
from
250ea8d to
b84b0d0
Compare
James Frost (jfrost-mo)
deleted the
2023_improve_aggregation_reliability
branch
James Frost (jfrost-mo)
temporarily deployed
to
github-pages
GitHub Actions
Inactive
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This opens up the aggregation recipes to support aggregating across single values, which while theoretically useless ensures that aggregation can remain enabled across varied data.
Testing on a single forecast (2026-04-07T05:00Z initialisation time) of MOGREPS-UK forecast PP files from MASS worked.
Fixes #2023.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.