Fix custom style file support in workflow#2029
Merged
Merged
Conversation
This was broken is two ways. The environment variable wasn't being set in the baking task, so the override wasn't being used, and the quoting was incorrect stopping the CYLC_WORKFLOW_SHARE_DIR expanding. Fixes #1990
James Frost (jfrost-mo)
added
bug
Member
Author
|
Evidence of it working: 
|
Contributor
|
|
refszkentla
approved these changes
Apr 7, 2026
Contributor
|
Thanks! You're fast, I was going to do it this week ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken is two ways. The environment variable wasn't being set in the baking task, so the override wasn't being used, and the quoting was incorrect stopping the CYLC_WORKFLOW_SHARE_DIR expanding.
Fixes #1990
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.