Use } as / replacement in symlink filenames#2092
Merged
James Frost (jfrost-mo) merged 1 commit intoMay 5, 2026
Merged
Conversation
Unlike ) the character } is not a shell metacharacter, and thus doesn't cause issues when not quoted. This is especially an issue as libnetcdf < 4.10 doesn't properly quote a shell command it uses, producing concerning (but ultimately harmless) log messages. Fixes #2083
James Frost (jfrost-mo)
added
bug
Contributor
|
|
James Frost (jfrost-mo)
requested review from
Scott Wales (ScottWales)
and removed request for
Scott Wales (ScottWales)
Member
Author
|
Given it is a tiny change I'm going to merge without review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike ) the character } is not a shell metacharacter, and thus doesn't cause issues when not quoted. This is especially an issue as libnetcdf < 4.10 doesn't properly quote a shell command it uses, producing concerning (but ultimately harmless) log messages.
Fixes #2083
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.