Skip to content

Fix/structure final-draft edits#28

Merged
Hamish Steptoe (hsteptoe) merged 49 commits into
developfrom
fix/structure
Jan 24, 2019
Merged

Fix/structure final-draft edits#28
Hamish Steptoe (hsteptoe) merged 49 commits into
developfrom
fix/structure

Conversation

@hsteptoe
Copy link
Copy Markdown
Member

@hsteptoe Hamish Steptoe (hsteptoe) commented Jan 22, 2019

Following Rosanna (@rosannaamato) review of draft worksheets, this pull request contains all the commits relating to those changes. Full review and summaries of changes made following Rosanna (@rosannaamato) review can be seen in #21

This final draft to be reviewed and tested by Cathryn Fox (@cathrynjfox)

rosanna.amato and others added 30 commits December 17, 2018 16:20
@cathrynjfox
Copy link
Copy Markdown

Cathryn Fox (cathrynjfox) commented Jan 22, 2019

Review and run-through of worksheets:

Worksheet 1
f) suggest adding short explanation of why 'pmi2' means 1982
h) it's a bit confusing that the pictured example is for air temperature but the loaded cube is for precipitation
j) this code block takes longer to run than the previous ones. Suggest saying that this will happen so that users don't think it isn't working (as I did).

Worksheet 2
2.1 - there is a good explanation of a cube here, but we have already met cubes in worksheet 1. Maybe this could be moved to worksheet 1?
e) The input and output file names are already specified in the code block, presumably so that later code loads them easily. Worth stating this in the instructions

Worksheet 3
a) The activity is to sort the lat and lons, but then they are already entered into the code box
c) There's a lot of unexplained functions in this code block i.e. weightings. Is this explained in the presentations? If not can a line be inserted to give a brief explanation. EDIT - this line exists in a note below the code block. Can it be moved to above?
e) I got a warning "Using DEFAULT_SPHERICAL_EARTH_RADIUS." - should this concern me?
Code block with line "aphro_monthly_mean.coord_system()" - why is this here?
Question about plotting aphro data - there isn't a block to put the code in, or any guidance on how to do this
f) Suggest a blue note box explaining what masking is
Code block containing the masking, I got a FutureWarning:

/opt/scitools/environments/experimental/2018_10_16-1/lib/python3.6/site-packages/numpy/ma/core.py:3169: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use arr[tuple(seq)] instead of arr[seq]. In the future this will be interpreted as an array index, arr[np.array(seq)], which will result either in an error or a different result.
dout = self.data[indx]
/opt/scitools/environments/experimental/2018_10_16-1/lib/python3.6/site-packages/iris/analysis/_scipy_interpolate.py:290: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use arr[tuple(seq)] instead of arr[seq]. In the future this will be interpreted as an array index, arr[np.array(seq)], which will result either in an error or a different result.
return self.values[idx_res]

Still f) We fixed the bit where it was trying to plot cahpa_cube instead of cahpa_regrid

Worksheet 4
a) I got an error:

/opt/scitools/environments/experimental/2018_10_16-1/lib/python3.6/site-packages/iris/fileformats/_pyke_rules/compiled_krb/fc_rules_cf_fc.py:2076: UserWarning: Failed to create 'grid_longitude' dimension coordinate: The points array must be strictly monotonic.
Gracefully creating 'grid_longitude' auxiliary coordinate instead.
error=e_msg))

But it still worked.
EDIT - Hamish fixed something and I no longer get this error

I added in the names of the two cubes to the green question box so that it was clearer.

b) I got a ValueError, Hamish fixed something and I no longer get an error.
c) We fixed this. Problems were
1) it was calling the time_periods key instead of the period
2) Hamish has already changed the units to C, so no longer need to do this

e) I got a UserWarning error about non-bounded coordinates, but it still worked.

h) You have to scroll a long way to remember what the original temp data files are called, suggest giving them in this code box

Worksheet 5
b) This was quite hard BUT I DID MANAGE IT HAMISH.
Had to scroll down to see what the filenames should be when plotting later, suggest providing the infile and outfile names as has happened in all previous examples. Also - that "number_aphro_days" should be called "number_aphro_days".

Worksheet 6
I have read through this for spellings, but not actually done the activity.

@cathrynjfox
Copy link
Copy Markdown

f07d4a9 pushed changes to worksheets following the review

This was referenced Jan 24, 2019
@hsteptoe Hamish Steptoe (hsteptoe) merged commit 431511f into develop Jan 24, 2019
@hsteptoe Hamish Steptoe (hsteptoe) deleted the fix/structure branch January 24, 2019 11:35
Hamish Steptoe (hsteptoe) added a commit that referenced this pull request Mar 15, 2019
* Issue #11, Implemented the changes proposed in Issue #11

* genraly style improvement and fixed a bug in the naming of the output files

* implemented the changes suggested by Hamish in the pull request comments for issue#11

* corrected typos, made the style more consistent and added addtional description for clarity

* code changes up to section 3.1c, where it is failing with a ValueError

* Updates to worksheet 1 file locations to reflect corrected pp files

* Add images

* Other minor corrections to worksheet 1

* Add processing of cahpb to worksheet 1

* Add data retrieval scripts

* Updates to python3 + consistency checks

* Minor fix to outfile naming in worksheet 1

* Add code to remove extraneous metadata to make cube comparisons easier later

* Clear all output

* Add script to make future data for Sec. 2.9

* Update MASS retrieval scripts

* Updates to 2b to reflect new file paths + other consistency edits

* Add code for making data specific to 2b

* Updates to data paths and minor plotting changes up to 3.1(b)

* Fixes up to 3.3, plus try adding Contents links

* Split final exercise of worksheet 3 into new worksheet 4

* Remove last section into worksheet 4. Other minor formatting changes

* Add Contents cell to each worksheet

* Add data compression settings on saving netcdf files

* Update .gitignore

* ÂRemove worksheet3 cell output

* Add descriptions of available data and extreme indicies

* Remove notebook checkpoints

* Remove old 2017 notebooks

* Add generator for chunking large daily future cube

* Fix/structure final-draft edits (#28)

Squashing and merging all changes following reviews by @rosannaamato and @cathrynjfox (covered in ticket #21 and pull request #28) in `develop`

* Add environment.yml for python env building and Binder set-up

* Add MO branding to all notebooks

* Formatting updates and reorder info

* Add conda environment details

* Add worksheet summary and re-structure info

* Update README.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Amended licence text

* Create data README

* Remove obsolete files from data dir

* Update .gitignore with additional ipynb location

* Initial commit of notebook style guide

* Add info on CONTRIBUTING.ipynb

* Update Contribution section

* Add info on data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants