Fix/structure final-draft edits#28
Conversation
…into fix/structure
…into fix/structure
|
Review and run-through of worksheets: Worksheet 1 Worksheet 2 Worksheet 3
Still f) We fixed the bit where it was trying to plot cahpa_cube instead of cahpa_regrid Worksheet 4
But it still worked. I added in the names of the two cubes to the green question box so that it was clearer. b) I got a ValueError, Hamish fixed something and I no longer get an error. e) I got a UserWarning error about non-bounded coordinates, but it still worked. h) You have to scroll a long way to remember what the original temp data files are called, suggest giving them in this code box Worksheet 5 Worksheet 6 |
|
f07d4a9 pushed changes to worksheets following the review |
* Issue #11, Implemented the changes proposed in Issue #11 * genraly style improvement and fixed a bug in the naming of the output files * implemented the changes suggested by Hamish in the pull request comments for issue#11 * corrected typos, made the style more consistent and added addtional description for clarity * code changes up to section 3.1c, where it is failing with a ValueError * Updates to worksheet 1 file locations to reflect corrected pp files * Add images * Other minor corrections to worksheet 1 * Add processing of cahpb to worksheet 1 * Add data retrieval scripts * Updates to python3 + consistency checks * Minor fix to outfile naming in worksheet 1 * Add code to remove extraneous metadata to make cube comparisons easier later * Clear all output * Add script to make future data for Sec. 2.9 * Update MASS retrieval scripts * Updates to 2b to reflect new file paths + other consistency edits * Add code for making data specific to 2b * Updates to data paths and minor plotting changes up to 3.1(b) * Fixes up to 3.3, plus try adding Contents links * Split final exercise of worksheet 3 into new worksheet 4 * Remove last section into worksheet 4. Other minor formatting changes * Add Contents cell to each worksheet * Add data compression settings on saving netcdf files * Update .gitignore * ÂRemove worksheet3 cell output * Add descriptions of available data and extreme indicies * Remove notebook checkpoints * Remove old 2017 notebooks * Add generator for chunking large daily future cube * Fix/structure final-draft edits (#28) Squashing and merging all changes following reviews by @rosannaamato and @cathrynjfox (covered in ticket #21 and pull request #28) in `develop` * Add environment.yml for python env building and Binder set-up * Add MO branding to all notebooks * Formatting updates and reorder info * Add conda environment details * Add worksheet summary and re-structure info * Update README.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Amended licence text * Create data README * Remove obsolete files from data dir * Update .gitignore with additional ipynb location * Initial commit of notebook style guide * Add info on CONTRIBUTING.ipynb * Update Contribution section * Add info on data
Following Rosanna (@rosannaamato) review of draft worksheets, this pull request contains all the commits relating to those changes. Full review and summaries of changes made following Rosanna (@rosannaamato) review can be seen in #21
This final draft to be reviewed and tested by Cathryn Fox (@cathrynjfox)