add timeout to fcm_bdiff #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bruten-mo
requested review from
Pierre-siddall,
jennyhickson,
r-sharp and
t00sa
and removed request for
a team,
Pierre-siddall and
r-sharp
jennyhickson
approved these changes
Apr 23, 2025
Collaborator
jennyhickson
left a comment
jennyhickson
left a comment
There was a problem hiding this comment.
Looks like a sensible modification. Assuming that 120 is plenty long enough for the bdiff itself to have either finished or got stuck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
With large changesets fcm_bdiff can fill the buffer, causing a hang - this is often seen with a non-appearing trac.log. This ticket adds a timeout to the fcm_bdiff subprocess, preventing the hang. This has been tested on a Apps branch with a large changeset.
Changes
Add timeout to fcm_bdiff subprocess command. Also changes from subprocess.popen to subprocess.run which is a nicer interface.
Dependency
Using subprocess.run with text=True, means fcm_bdiff now requires python3.9.
Checklist