Stop reliance on hashable args#97
Merged
Stephen Moseley (MoseleyS) merged 3 commits intomainfrom Oct 21, 2025
Merged
Conversation
Stephen Moseley (MoseleyS)
previously approved these changes
Oct 17, 2025
Member
Stephen Moseley (MoseleyS)
left a comment
There was a problem hiding this comment.
This branch fixes the issue we've recently uncovered with handling unhashable CubeList objects
Collaborator
Author
|
It's now out of draft and ready for review Rob Purvis (@mo-robert-purvis), Stephen Moseley (@MoseleyS) |
Rob Purvis (mo-robert-purvis)
approved these changes
Oct 21, 2025
Stephen Moseley (MoseleyS)
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A set is used to perform argument checking logic. Using a set enforces a requirements that the arguments are hashable (which they may not always be).
The relevant line:
dagrunner/dagrunner/execute_graph.py
Line 106 in 0b98a63
We can recreate the exception manually: