rename self.exe attribute#149
Merged
MatthewHambley merged 8 commits intoMetOffice:masterfrom Oct 24, 2022
Merged
Conversation
Merged
MatthewHambley
previously approved these changes
Oct 18, 2022
Collaborator
MatthewHambley
left a comment
MatthewHambley
left a comment
There was a problem hiding this comment.
A simple change which improves readability.
# Conflicts: # source/fab/steps/compile_fortran.py
MatthewHambley
requested changes
Oct 20, 2022
Collaborator
MatthewHambley
left a comment
MatthewHambley
left a comment
There was a problem hiding this comment.
Noticed an oddity
source/fab/steps/compile_fortran.py
Outdated
| common_flags = common_flags or [] | ||
| env_flags = os.getenv('FFLAGS', '').split() | ||
| self.exe: str = compiler or os.getenv('FC', 'gfortran -c') # type: ignore | ||
| self.compiler: str = compiler or os.getenv('FC', 'gfortran -c') # type: ignore |
Collaborator
There was a problem hiding this comment.
We seem to have two instances of compiler or os.getenv('FC', 'gfortran -c'), here and line 65. Is that intended?
Contributor
Author
There was a problem hiding this comment.
It's my use of the magic wand merge button again. I did say I would be more vigilant with it's use...sorry!
MatthewHambley
previously approved these changes
Oct 21, 2022
Collaborator
MatthewHambley
left a comment
MatthewHambley
left a comment
There was a problem hiding this comment.
Doubled up compiler determination fixed.
# Conflicts: # source/fab/steps/compile_fortran.py # source/fab/steps/preprocess.py
MatthewHambley
approved these changes
Oct 24, 2022
Collaborator
MatthewHambley
left a comment
MatthewHambley
left a comment
There was a problem hiding this comment.
As noted by the developers, many of the changes originally in this patch have been swept up in others that there isn't much left.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actioning this review comment, self.exe is renamed for better readability.