Picasso #206
Merged
Picasso #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matthewrmshin
left a comment
matthewrmshin
left a comment
There was a problem hiding this comment.
Looks good, but recommend that you use the python3 command instead of the python command. Some newer Linux distro versions have chosen to only provide a python3 command and not a python command.
envs/picasso/image.yml
Outdated
| - matplotlib | ||
|
|
||
| commands: | ||
| - python setup.py install |
Contributor
There was a problem hiding this comment.
Recommend using the python3 command here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to manually trigger a Picasso build, giving us a singularity container with Fab and dependencies. It's based on a recent version of Ubuntu with a newer glibc than on the VDI.
Follow up work might branch out into multiple images:
We probably don't want to trigger these builds from push or prs because a) we probably only need to build infrequently and b) due to the cross-repo nature of the action we'd need to give fab forks (i.e anyone) source permissions to the source repo. A disadvantage of this that I don't think we can quickly iterate with PRs to tweak the Picasso config, we have to wait until it's merged before we can see if it works.