Open
Conversation
Joerg Henrichs (hiker)
requested review from
a team and
Pierre Siddall (Pierre-siddall)
and removed request for
a team
Joerg Henrichs (hiker)
added
um
Ready for review
Collaborator
Author
|
I've labeled it for the UM release. While it is strictly speaking, it's Socrates that needs it, not UM (and socrates is already built as part of UM/lfric as required), but it's a small change only, so I don't think we need it as a separate mile stone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #555. I've updated/added tests for multiple C programs, and can also confirm that this version is able to build multiple Socrates C executables.
I have also fixed the symbol handling (C symbols are case dependent, only Fortran symbols are not). And as a result of the change the output filename of a C main program is now changed from
mainto be the same as the main source file name (without.c).