Fab for lfric#564
Closed
Joerg Henrichs (hiker) wants to merge 20 commits into
Closed
Conversation
… cases (e.g. when just running this one test).
24 tasks
Collaborator
Author
|
Oops, wrong branch. #565 is the right PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds changes and improvements done, based on the code review for lfric_core and UM (plus pfunit for lfric core).
It's mostly a collection of small changes, but I've renamed
root_symboltoroot_symbols, since this has always been a list, and is frequently used this way (e.g. um builds um and recon; socrates has over 50 binaries, ...). I left the old names in place with a deprecation warning for now.